[mono][aot] Fix infinite recursion in the AOT dwarf emitter. #79310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vargaz
force-pushed
the
aot-dwarf-recursion
branch
from
b963e60
to
338f413
Compare
lambdageek
approved these changes
Dec 7, 2022
The recursion would happen if a gshared type would contain a recursive reference to it. It was triggered by the JsonTypeInfo:JsonTypeInfo<Queue<T>> field added by dotnet#78646. Fixes dotnet#79279.
vargaz
force-pushed
the
aot-dwarf-recursion
branch
from
338f413
to
2e9700c
Compare
|
should we backport this? |
|
Never seen any customer reports about this, seems to be a very rare case. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursion would happen if a gshared type would contain a recursive reference to it. It was triggered by the JsonTypeInfo:JsonTypeInfo<Queue> field added by #78646.
Fixes #79279.